-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating multiple backports from one pull request #18
Conversation
|
Apparently when backporting to multiple branches, there is only one comment about a backport failure, even if multiple backports fail. This makes it hard to quickly see which backports need to be done manually. @tibdex do you have an idea why this is? Some throttling on github side maybe? |
|
It's because I use Lines 137 to 141 in 35fd5c5
And its doc says:
It would indeed be better to try them all, even if one rebase failed. |
|
That sounds reasonable. |
|
Tracking this with #27, the fix should be fairly easy. |
|
In fact I fail to understand the documentation you cited. From what I can see it mentions the aggregated end result of the promise but doesn't talk about continuation after a rejected function. |
|
You can see the fix in c252bc6, tell me if you don't understand something ;) |
Fix #17
Disclaimer: I have never written TypeScript before and have used the github online editor. Needs careful review!