Skip to content

ci(fix): temporary removing cosign verification #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasehlert merged 1 commit into from
Dec 7, 2025
Merged

ci(fix): temporary removing cosign verification #564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,21 +239,21 @@ jobs:
docker buildx imagetools inspect ghcr.io/${{ github.repository }}:${{ steps.docker_meta.outputs.version }} --format '{{ json (index .SBOM "linux/amd64") }}'
echo "::endgroup::"

- name: Verify cosign signatures
run: |
echo "::group::Verify signature (DockerHub)"
cosign verify --rekor-url https://rekor.sigstore.dev \
--certificate-identity "https://github.com/${{ github.workflow_ref }}" \
--certificate-oidc-issuer "https://token.actions.githubusercontent.com" \
${{ github.repository }}@${{ steps.docker_build.outputs.digest }}
echo "::endgroup::"

echo "::group::Verify signature (GitHub Container Registry)"
cosign verify --rekor-url https://rekor.sigstore.dev \
--certificate-identity "https://github.com/${{ github.workflow_ref }}" \
--certificate-oidc-issuer "https://token.actions.githubusercontent.com" \
ghcr.io/${{ github.repository }}@${{ steps.docker_build.outputs.digest }}
echo "::endgroup::"
# - name: Verify cosign signatures
# run: |
# echo "::group::Verify signature (DockerHub)"
# cosign verify --rekor-url https://rekor.sigstore.dev \
# --certificate-identity "https://github.com/${{ github.workflow_ref }}" \
# --certificate-oidc-issuer "https://token.actions.githubusercontent.com" \
# ${{ github.repository }}@${{ steps.docker_build.outputs.digest }}
# echo "::endgroup::"

# echo "::group::Verify signature (GitHub Container Registry)"
# cosign verify --rekor-url https://rekor.sigstore.dev \
# --certificate-identity "https://github.com/${{ github.workflow_ref }}" \
# --certificate-oidc-issuer "https://token.actions.githubusercontent.com" \
# ghcr.io/${{ github.repository }}@${{ steps.docker_build.outputs.digest }}
# echo "::endgroup::"
Comment on lines +242 to +256
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a temporary removal (as indicated by the PR title), consider adding a TODO comment with a tracking issue or explanation. This will help ensure the verification step is re-enabled in the future and provide context for why it was temporarily disabled.

Example:

# TODO: Re-enable cosign verification once [issue/reason] is resolved
# Temporarily disabled due to [specific reason]
# - name: Verify cosign signatures

Copilot uses AI. Check for mistakes.
Comment on lines +242 to +256
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out the verification step while keeping the signing step (lines 214-220) creates an inconsistency in the CI pipeline. Images are still being signed but the signatures are no longer being verified, which defeats the purpose of signing.

If verification is causing issues, consider whether the signing step should also be temporarily disabled, or ensure there's a plan to re-enable verification soon to maintain the security benefits of the signing process.

Suggested change
# - name: Verify cosign signatures
# run: |
# echo "::group::Verify signature (DockerHub)"
# cosign verify --rekor-url https://rekor.sigstore.dev \
# --certificate-identity "https://github.com/${{ github.workflow_ref }}" \
# --certificate-oidc-issuer "https://token.actions.githubusercontent.com" \
# ${{ github.repository }}@${{ steps.docker_build.outputs.digest }}
# echo "::endgroup::"
# echo "::group::Verify signature (GitHub Container Registry)"
# cosign verify --rekor-url https://rekor.sigstore.dev \
# --certificate-identity "https://github.com/${{ github.workflow_ref }}" \
# --certificate-oidc-issuer "https://token.actions.githubusercontent.com" \
# ghcr.io/${{ github.repository }}@${{ steps.docker_build.outputs.digest }}
# echo "::endgroup::"
- name: Verify cosign signatures
run: |
echo "::group::Verify signature (DockerHub)"
cosign verify --rekor-url https://rekor.sigstore.dev \
--certificate-identity "https://github.com/${{ github.workflow_ref }}" \
--certificate-oidc-issuer "https://token.actions.githubusercontent.com" \
${{ github.repository }}@${{ steps.docker_build.outputs.digest }}
echo "::endgroup::"
echo "::group::Verify signature (GitHub Container Registry)"
cosign verify --rekor-url https://rekor.sigstore.dev \
--certificate-identity "https://github.com/${{ github.workflow_ref }}" \
--certificate-oidc-issuer "https://token.actions.githubusercontent.com" \
ghcr.io/${{ github.repository }}@${{ steps.docker_build.outputs.digest }}
echo "::endgroup::"

Copilot uses AI. Check for mistakes.

argocd:
if: github.event_name == 'release' || (github.event_name == 'push' && github.ref == 'refs/heads/main')
Expand Down