Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textbyt app doesn't scroll when text goes off screen #698

Closed
mcorby17 opened this issue Sep 28, 2022 · 7 comments · Fixed by #772
Closed

Textbyt app doesn't scroll when text goes off screen #698

mcorby17 opened this issue Sep 28, 2022 · 7 comments · Fixed by #772

Comments

@mcorby17
Copy link

mcorby17 commented Sep 28, 2022

Screen_Recording_20221102-184438_1.mp4
@rs7q5
Copy link
Contributor

rs7q5 commented Oct 2, 2022

Cc @joshareed

@joshareed
Copy link
Contributor

Thanks for the bug report. The app is using a Marquee with vertical scroll setup, so I'm at a loss as to why it isn't working. I'll sign up as a beta tester to test it out myself.

@mcorby17
Copy link
Author

Thanks for looking into it! Sorry I should have provided a screenshot. I'd do it now but I'm away from home for a week.

@mcorby17
Copy link
Author

@joshareed hey I tested it today and it scrolled so I guess the problem is resolved 😅

@mcorby17 mcorby17 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2022
@mcorby17 mcorby17 reopened this Nov 2, 2022
@mcorby17
Copy link
Author

mcorby17 commented Nov 2, 2022

@joshareed I saw it happen again. I think it depends on how long the message is, if it's long enough to go off the screen but not long enough to go off the container for the text then it doesn't scroll.

Try playing around with different text lengths. Here is the text I sent that made it fail to scroll:

Hiiii I love you and hope you're having a great day!! :)

@joshareed
Copy link
Contributor

Thanks for the tip. I've got it installed and I'll try reproducing it. I probably forgot to shrink the height of the marquee to account for the name header.

@joshareed
Copy link
Contributor

I was able to reproduce on my Tidbyt and locally in the simulator. It was what I suspected above--I had set the height of the Marquee widget to the full height of the Tidbyt. It didn't account for the fixed header line. It was a quick fix and things started working properly in the similar. I submitted a PR to fix it. Once merged, it should roll out on the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants