Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix datahelper tests #121
I believe these tests broke with commit 0b010fe
At that point joinKey was passed through but the test wasn't expecting it so the deep.equals failed. However, I'm not sure about all the details of how the bolus conversion is supposed to work so maybe the test is failing because of a true bug. I suspect it is the test that is in error though.
I'm also rolling #120 into this PR.
Thanks @andersp! Good catch on the documentation & bug in the tests.
I'll merge this in just a bit, but before I can we have a little formality: could you please agree to our CLA, see "Making Contributions" at http://tidepool-org.github.io/Contributors.html, by pasting in the text "I agree to the terms of..." here in this GitHub PR? Thanks!