Fix datahelper tests#121
Merged
nicolashery merged 2 commits intotidepool-org:masterfrom Aug 15, 2014
Merged
Conversation
Tests were failing due to deep equals not finding joinKey. Adding joinKey to the compared arrays fixes it.
Contributor
|
Thanks @andersp! Good catch on the documentation & bug in the tests. I'll merge this in just a bit, but before I can we have a little formality: could you please agree to our CLA, see "Making Contributions" at http://tidepool-org.github.io/Contributors.html, by pasting in the text "I agree to the terms of..." here in this GitHub PR? Thanks! |
Contributor
Author
|
You bet: I agree to the terms of Tidepool Project’s Contributor License Agreement as it exists at http://tidepool-org.github.io/TidepoolCLA.pdf on 2014-08-15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe these tests broke with commit 0b010fe
At that point joinKey was passed through but the test wasn't expecting it so the deep.equals failed. However, I'm not sure about all the details of how the bolus conversion is supposed to work so maybe the test is failing because of a true bug. I suspect it is the test that is in error though.
I'm also rolling #120 into this PR.