Fix datahelper tests #121

Merged
merged 2 commits into from Aug 15, 2014

Conversation

Projects
None yet
2 participants
@anderspitman
Contributor

anderspitman commented Aug 15, 2014

I believe these tests broke with commit 0b010fe

At that point joinKey was passed through but the test wasn't expecting it so the deep.equals failed. However, I'm not sure about all the details of how the bolus conversion is supposed to work so maybe the test is failing because of a true bug. I suspect it is the test that is in error though.

I'm also rolling #120 into this PR.

anderspitman added some commits Aug 14, 2014

Fix dataHelpers tests
Tests were failing due to deep equals not finding joinKey.
Adding joinKey to the compared arrays fixes it.
@nicolashery

This comment has been minimized.

Show comment
Hide comment
@nicolashery

nicolashery Aug 15, 2014

Contributor

Thanks @andersp! Good catch on the documentation & bug in the tests.

I'll merge this in just a bit, but before I can we have a little formality: could you please agree to our CLA, see "Making Contributions" at http://tidepool-org.github.io/Contributors.html, by pasting in the text "I agree to the terms of..." here in this GitHub PR? Thanks!

Contributor

nicolashery commented Aug 15, 2014

Thanks @andersp! Good catch on the documentation & bug in the tests.

I'll merge this in just a bit, but before I can we have a little formality: could you please agree to our CLA, see "Making Contributions" at http://tidepool-org.github.io/Contributors.html, by pasting in the text "I agree to the terms of..." here in this GitHub PR? Thanks!

@anderspitman

This comment has been minimized.

Show comment
Hide comment
@anderspitman

anderspitman Aug 15, 2014

Contributor

You bet:

I agree to the terms of Tidepool Project’s Contributor License Agreement as it exists at http://tidepool-org.github.io/TidepoolCLA.pdf on 2014-08-15

Contributor

anderspitman commented Aug 15, 2014

You bet:

I agree to the terms of Tidepool Project’s Contributor License Agreement as it exists at http://tidepool-org.github.io/TidepoolCLA.pdf on 2014-08-15

nicolashery added a commit that referenced this pull request Aug 15, 2014

@nicolashery nicolashery merged commit fedd8ea into tidepool-org:master Aug 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment