Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviates dates in the patient data charts and brings arrows in closer. #182

Merged
merged 7 commits into from
Jan 13, 2015

Conversation

ursooperduper
Copy link
Contributor

This PR abbreviates the dates shown in daily, weekly, and trend views of patient data.
@jebeck @skrugman

To tighten the position of the arrows, I removed a large block element that surrounded the dates in each view. When you test this, you'll notice that this causes the arrows to bounce slightly as the width of the date string changes. In my testing, I found that you can still click the arrows repeatedly to move forward or backward in time without losing focus.

If the slight jump/bounce of the arrows is undesirable, I can create CSS rules for each view that will reintroduce the block around the date, just a bit tighter than before when there was one block for all views.

Let me know how you'd like me to proceed!

Resolves: https://trello.com/c/RELPBpRy

I agree to the terms of Tidepool Project’s Volunteer/Contributor License Agreement v1.0
as it exists at http://tidepool-org.github.io/TidepoolVCLA.pdf on Monday, January 12, 2015.
cc/ @kentquirk

@@ -117,7 +117,7 @@ var Daily = React.createClass({
else {
timezone = timePrefs.timezoneName || 'UTC';
}
return sundial.formatInTimezone(datetime, timezone, 'dddd, MMMM Do');
return sundial.formatInTimezone(datetime, timezone, 'ddd, MMM D, YYYY');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep ordinal markers after the dates? e.g., 14th instead of 14?

This is a question as much for @skrugman and @brandonarbiter

If yes, everywhere or just daily view?

padding-left: 0;
padding-right: 0;
// padding-left: 0;
// padding-right: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete commented out lines?

@jebeck
Copy link
Contributor

jebeck commented Jan 13, 2015

Just waiting on deletion of commented-out code and another update merge from master; otherwise looks good.

@ursooperduper
Copy link
Contributor Author

@jebeck
Removed all the commented out code. Sorry about that! The branch is merged and the build passes.

@jebeck
Copy link
Contributor

jebeck commented Jan 13, 2015

Awesome, thanks!

jebeck added a commit that referenced this pull request Jan 13, 2015
Abbreviates dates in the patient data charts and brings arrows in closer.
@jebeck jebeck merged commit 6f186ee into tidepool-org:master Jan 13, 2015
@ursooperduper ursooperduper deleted the sk/arrows-and-dates branch January 15, 2015 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants