Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviates dates in the patient data charts and brings arrows in closer. #182

Merged
merged 7 commits into from Jan 13, 2015

Conversation

@ursooperduper
Copy link
Contributor

@ursooperduper ursooperduper commented Jan 12, 2015

This PR abbreviates the dates shown in daily, weekly, and trend views of patient data.
@jebeck @skrugman

To tighten the position of the arrows, I removed a large block element that surrounded the dates in each view. When you test this, you'll notice that this causes the arrows to bounce slightly as the width of the date string changes. In my testing, I found that you can still click the arrows repeatedly to move forward or backward in time without losing focus.

If the slight jump/bounce of the arrows is undesirable, I can create CSS rules for each view that will reintroduce the block around the date, just a bit tighter than before when there was one block for all views.

Let me know how you'd like me to proceed!

Resolves: https://trello.com/c/RELPBpRy

I agree to the terms of Tidepool Project’s Volunteer/Contributor License Agreement v1.0
as it exists at http://tidepool-org.github.io/TidepoolVCLA.pdf on Monday, January 12, 2015.
cc/ @kentquirk

…element around date to bring arrows in closer to dates.
@@ -117,7 +117,7 @@ var Daily = React.createClass({
else {
timezone = timePrefs.timezoneName || 'UTC';
}
return sundial.formatInTimezone(datetime, timezone, 'dddd, MMMM Do');
return sundial.formatInTimezone(datetime, timezone, 'ddd, MMM D, YYYY');

This comment has been minimized.

@jebeck

jebeck Jan 13, 2015
Contributor

Do we want to keep ordinal markers after the dates? e.g., 14th instead of 14?

This is a question as much for @skrugman and @brandonarbiter

If yes, everywhere or just daily view?

@@ -33,16 +33,21 @@

.patient-data-subnav-text {
display: inline-block;
padding: @patient-data-subnav-vertical-padding @patient-data-subnav-horizontal-padding;
padding: @patient-data-subnav-vertical-padding 0 @patient-data-subnav-horizontal-padding 0;

This comment has been minimized.

@jebeck

jebeck Jan 13, 2015
Contributor

There's a funny thing going one when the app is in the loading data state (title bar gets really vertically skinny), and I think this change might be the root?
screenshot 2015-01-13 10 19 44

To get a good long look at it you can use "mock" mode and and the URL http://localhost:3000/?api.patientdata.get.delay=5000#/patients/11/data (auth.skip in mock mode seems to be broken though...)

This comment has been minimized.

@skrugman

skrugman Jan 13, 2015

Lets get rid of the th after the #

*Sara Krugman *
Lead designer

*Tidepool *An open source, not-for-profit effort to build an open data
platform and better applications that reduce the burden of Type 1 Diabetes
and accelerate the commercialization of closed-loop systems.

Phone : 617 549 1483
*Email : *sara@tidepool.org
*Web : *Tidepool.org http://tidepool.org/

On Tue, Jan 13, 2015 at 10:24 AM, Jana Beck notifications@github.com
wrote:

In app/pages/patientdata/patientdata.less
#182 (diff):

@@ -33,16 +33,21 @@

.patient-data-subnav-text {
display: inline-block;

  • padding: @patient-data-subnav-vertical-padding @patient-data-subnav-horizontal-padding;
  • padding: @patient-data-subnav-vertical-padding 0 @patient-data-subnav-horizontal-padding 0;

There's a funny thing going one when the app is in the loading data state
(title bar gets really vertically skinny), and I think this change might be
the root?
[image: screenshot 2015-01-13 10 19 44]
https://cloud.githubusercontent.com/assets/1588547/5726139/f5f1965c-9b0d-11e4-859f-daa750ee84a0.png

To get a good long look at it you can use "mock" mode and and the URL
http://localhost:3000/?api.patientdata.get.delay=5000#/patients/11/data
(auth.skip in mock mode seems to be broken though...)


Reply to this email directly or view it on GitHub
https://github.com/tidepool-org/blip/pull/182/files#r22882329.

This comment has been minimized.

@ursooperduper

ursooperduper Jan 13, 2015
Author Contributor

I definitely introduced that one! It's fixed in my latest commit. There was inconsistent padding on linked header items versus plain text. I've correct that and cleaned up a bit!

padding-left: 0;
padding-right: 0;
// padding-left: 0;
// padding-right: 0;

This comment has been minimized.

@jebeck

jebeck Jan 13, 2015
Contributor

Can you delete commented out lines?

@jebeck
Copy link
Contributor

@jebeck jebeck commented Jan 13, 2015

Just waiting on deletion of commented-out code and another update merge from master; otherwise looks good.

@ursooperduper
Copy link
Contributor Author

@ursooperduper ursooperduper commented Jan 13, 2015

@jebeck
Removed all the commented out code. Sorry about that! The branch is merged and the build passes.

@jebeck
Copy link
Contributor

@jebeck jebeck commented Jan 13, 2015

Awesome, thanks!

jebeck added a commit that referenced this pull request Jan 13, 2015
Abbreviates dates in the patient data charts and brings arrows in closer.
@jebeck jebeck merged commit 6f186ee into tidepool-org:master Jan 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@ursooperduper ursooperduper deleted the ursooperduper:sk/arrows-and-dates branch Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.