Abbreviates dates in the patient data charts and brings arrows in closer. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…element around date to bring arrows in closer to dates.
| @@ -117,7 +117,7 @@ var Daily = React.createClass({ | |||
| else { | |||
| timezone = timePrefs.timezoneName || 'UTC'; | |||
| } | |||
| return sundial.formatInTimezone(datetime, timezone, 'dddd, MMMM Do'); | |||
| return sundial.formatInTimezone(datetime, timezone, 'ddd, MMM D, YYYY'); | |||
There was a problem hiding this comment.
Do we want to keep ordinal markers after the dates? e.g., 14th instead of 14?
This is a question as much for @skrugman and @brandonarbiter
If yes, everywhere or just daily view?
| padding-left: 0; | ||
| padding-right: 0; | ||
| // padding-left: 0; | ||
| // padding-right: 0; |
There was a problem hiding this comment.
Can you delete commented out lines?
|
Just waiting on deletion of commented-out code and another update merge from master; otherwise looks good. |
|
@jebeck |
|
Awesome, thanks! |
jebeck
added a commit
that referenced
this pull request
Jan 13, 2015
Abbreviates dates in the patient data charts and brings arrows in closer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abbreviates the dates shown in daily, weekly, and trend views of patient data.
@jebeck @skrugman
To tighten the position of the arrows, I removed a large block element that surrounded the dates in each view. When you test this, you'll notice that this causes the arrows to bounce slightly as the width of the date string changes. In my testing, I found that you can still click the arrows repeatedly to move forward or backward in time without losing focus.
If the slight jump/bounce of the arrows is undesirable, I can create CSS rules for each view that will reintroduce the block around the date, just a bit tighter than before when there was one block for all views.
Let me know how you'd like me to proceed!
Resolves: https://trello.com/c/RELPBpRy
I agree to the terms of Tidepool Project’s Volunteer/Contributor License Agreement v1.0
as it exists at http://tidepool-org.github.io/TidepoolVCLA.pdf on Monday, January 12, 2015.
cc/ @kentquirk