eliminate React warnings re: api deprecation and increase test coverage #234
Conversation
- removed usage of 'transferPropsTo' - changed React.PropTypes.component -> React.PropTypes.element - changed React.PropTypes.renderable -> React.PropTypes.node - removed unused property 'patientsComponent' - added test coverage for the changes Issue: tidepool-org#228
|
Thanks. I did see the contributor guidelines and included my agreement disclaimer in the pull request body above, but I'm happy to move it to a separate comment if that is the official place for it. |
|
I agree to the terms of Tidepool Project’s Volunteer/Contributor License Agreement v1.0 |
|
Weirdly, I can't see the VCLA agreement in the body of the PR here on GitHub, only in my e-mail?? Did you edit it? In any case, thanks for the agreement by way of comment. Will be reviewing this likely later this week. Currently have other priorities and need to wait for some recent changes on master to go through QA. After that will be trying to pull in new-testing branch hopefully along with this. Will let you know if I have any questions/comments. Thanks again! |
|
No black magic going on, I updated the PR body to remove the disclaimer and added as a comment instead :) Thanks for the update - no rush on my end. |
| @@ -22,7 +22,6 @@ var personUtils = require('../../core/personutils'); | |||
| var Invitation = React.createClass({ | |||
| propTypes: { | |||
| invitation: React.PropTypes.object, | |||
| patientsComponent: React.PropTypes.component, | |||
There was a problem hiding this comment.
So I guess it looks like we're just not actually using this in the Invitation component. Can we remove where this prop is passed in too?
There was a problem hiding this comment.
Yes, of course. I had intended to do that. Good catch!
- replaced manual prop transfer with JSX spread in Patient - required theNote prop on Message, added test case - removed passing of unused patientsComponent prop to Invitation
|
Thanks again for this! Merging :) |
eliminate React warnings re: api deprecation and increase test coverage
Hi,
When I was checking out your app I noticed some warnings in the console and here is a patch to fix them. Do let me know if there is a better option than targeting this branch - I don't know the codebase well so I wanted to include test coverage to validate that my changes weren't breaking anything, and the best place to accomplish that at the moment was in this branch (as I wasn't able to run tests effectively in master).
Commit Message
Issue: #228