Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent error codes #738

Open
wants to merge 6 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@jweismann
Copy link

jweismann commented Dec 20, 2018

I noticed an inconsistency in the error-codes shown on the PDM and the ones recorded in the data object of the IBF parser. It seems to be an off-by-one issue that is fixed by a tiny change in the field format.

Thanks a lot for sharing the source code for this extremely valuable IBF parser.

Cheers

jweismann added some commits Dec 20, 2018

ensure that error codes are consistent with the codes present on the …
…PDM - fixing an off-by-one issue in parsing the raw bytes

@pazaan pazaan requested a review from gniezen Dec 20, 2018

@gniezen

This comment has been minimized.

Copy link
Member

gniezen commented Jan 30, 2019

@jweismann Would you mind adding a comment on this PR to state you agree to the Tidepool Contributor License Agreement? See the following for how to go about doing this: https://developer.tidepool.org/contributors/

@jweismann

This comment has been minimized.

Copy link
Author

jweismann commented Jan 31, 2019

@gniezen I agree to the Tidepool Contributor License Agreement. Thanks!

@gniezen

gniezen approved these changes Feb 7, 2019

Copy link
Member

gniezen left a comment

LGTM! :shipit: I'll see if I can merge this into the next release.

gniezen added some commits Feb 13, 2019

@gniezen

This comment has been minimized.

Copy link
Member

gniezen commented Feb 25, 2019

@gniezen

This comment has been minimized.

Copy link
Member

gniezen commented Feb 25, 2019

PR is now successfully passing CI checks after #772 was merged, where we now avoid forked builds but still allow units tests and linting to run.

This PR should be merged together with new OmniPod Dash work (see linked Trello card), so that it can be tested together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.