New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coverage reporting #201

Merged
merged 1 commit into from Feb 1, 2015

Conversation

Projects
None yet
2 participants
@dduugg
Contributor

dduugg commented Jan 31, 2015

This contribution is based on an email conversation with @brandonarbiter and @jebeck. A Tideline admin will need to enable the repo at coveralls.io before the coverage info will appear on the README badge, but a working example using my own fork looks like this.

I agree to the terms of Tidepool Project’s Contributor License Agreement as it exists at http://tidepool-org.github.io/TidepoolCLA.pdf on 2015-01-31

@@ -1,7 +1,7 @@
language: node_js
node_js:
- "0.10"
- "0.10"

This comment has been minimized.

@dduugg

dduugg Jan 31, 2015

Contributor

Just cleaning up formatting here. One change to consider though (if you haven't already) is to add "0.11" as a node version to test, but to allow failures (since 0.11 it is an unstable release). This will let you monitor potentially breaking changes. See the express configuration.

@dduugg

dduugg Jan 31, 2015

Contributor

Just cleaning up formatting here. One change to consider though (if you haven't already) is to add "0.11" as a node version to test, but to allow failures (since 0.11 it is an unstable release). This will let you monitor potentially breaking changes. See the express configuration.

@@ -1,7 +1,8 @@
tideline
========
[![Build Status](https://travis-ci.org/tidepool-org/tideline.png?branch=master)](https://travis-ci.org/tidepool-org/tideline)
[![Build Status](https://img.shields.io/travis/tidepool-org/tideline/master.svg)](https://travis-ci.org/tidepool-org/tideline)

This comment has been minimized.

@dduugg

dduugg Jan 31, 2015

Contributor

Switching the build status badge to use shields.io for consistent look and feel.

@dduugg

dduugg Jan 31, 2015

Contributor

Switching the build status badge to use shields.io for consistent look and feel.

- "npm run jshint"
- "npm run travis"
after_script: "npm install coveralls && cat ./coverage/lcov.info | coveralls"

This comment has been minimized.

@dduugg

dduugg Feb 1, 2015

Contributor

It is common to specify a specific version of coveralls to install here (again, see express), though I prefer to always use the latest. Let me know if you prefer something else here.

@dduugg

dduugg Feb 1, 2015

Contributor

It is common to specify a specific version of coveralls to install here (again, see express), though I prefer to always use the latest. Let me know if you prefer something else here.

@jh-bate

This comment has been minimized.

Show comment
Hide comment
@jh-bate

jh-bate Feb 1, 2015

Contributor

awesome - thanks for the contribution @dduugg! will take a proper look tonight and then merge.

Contributor

jh-bate commented Feb 1, 2015

awesome - thanks for the contribution @dduugg! will take a proper look tonight and then merge.

@jh-bate

This comment has been minimized.

Show comment
Hide comment
@jh-bate

jh-bate Feb 1, 2015

Contributor

Have turned on coveralls so now merging

Contributor

jh-bate commented Feb 1, 2015

Have turned on coveralls so now merging

jh-bate added a commit that referenced this pull request Feb 1, 2015

@jh-bate jh-bate merged commit 5ddcee0 into tidepool-org:master Feb 1, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment