Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coverage reporting #201

Merged
merged 1 commit into from Feb 1, 2015
Merged

add coverage reporting #201

merged 1 commit into from Feb 1, 2015

Conversation

@dduugg
Copy link
Contributor

@dduugg dduugg commented Jan 31, 2015

This contribution is based on an email conversation with @brandonarbiter and @jebeck. A Tideline admin will need to enable the repo at coveralls.io before the coverage info will appear on the README badge, but a working example using my own fork looks like this.

I agree to the terms of Tidepool Project’s Contributor License Agreement as it exists at http://tidepool-org.github.io/TidepoolCLA.pdf on 2015-01-31

@@ -1,7 +1,7 @@
language: node_js
node_js:
- "0.10"

- "0.10"
Copy link
Contributor Author

@dduugg dduugg Jan 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cleaning up formatting here. One change to consider though (if you haven't already) is to add "0.11" as a node version to test, but to allow failures (since 0.11 it is an unstable release). This will let you monitor potentially breaking changes. See the express configuration.

Loading

@jh-bate
Copy link
Contributor

@jh-bate jh-bate commented Feb 1, 2015

awesome - thanks for the contribution @dduugg! will take a proper look tonight and then merge.

Loading

@jh-bate
Copy link
Contributor

@jh-bate jh-bate commented Feb 1, 2015

Have turned on coveralls so now merging

Loading

jh-bate added a commit that referenced this issue Feb 1, 2015
@jh-bate jh-bate merged commit 5ddcee0 into tidepool-org:master Feb 1, 2015
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants