Consistent error codes #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PDM - fixing an off-by-one issue in parsing the raw bytes
|
@jweismann Would you mind adding a comment on this PR to state you agree to the Tidepool Contributor License Agreement? See the following for how to go about doing this: https://developer.tidepool.org/contributors/ |
|
@gniezen I agree to the Tidepool Contributor License Agreement. Thanks! |
gniezen
approved these changes
Feb 7, 2019
I'll see if I can merge this into the next release.
|
PR is now successfully passing CI checks after #772 was merged, where we now avoid forked builds but still allow units tests and linting to run. This PR should be merged together with new OmniPod Dash work (see linked Trello card), so that it can be tested together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an inconsistency in the error-codes shown on the PDM and the ones recorded in the data object of the IBF parser. It seems to be an off-by-one issue that is fixed by a tiny change in the field format.
Thanks a lot for sharing the source code for this extremely valuable IBF parser.
Cheers