From 14cd341a3922a26d8279e66d8e41aa0ac2686dd4 Mon Sep 17 00:00:00 2001
From: Chris Williams <chris.a.williams@gmail.com>
Date: Tue, 26 Nov 2019 10:57:25 -0500
Subject: [PATCH] refactor(ios): remove deprecated properties on ipad popover

    This removes the height, width, leftNavButton and rightNavButton properties that have been deprecated since sdk
    3.4.2

    BREAKING CHANGE: Removes deprecated ipad popover properties: height, width, leftNavButton and rightNavButton
---
 iphone/Classes/TiUIiPadPopoverProxy.m | 57 +--------------------------
 1 file changed, 1 insertion(+), 56 deletions(-)

diff --git a/iphone/Classes/TiUIiPadPopoverProxy.m b/iphone/Classes/TiUIiPadPopoverProxy.m
index 010fce2ed77..4cdd8438194 100644
--- a/iphone/Classes/TiUIiPadPopoverProxy.m
+++ b/iphone/Classes/TiUIiPadPopoverProxy.m
@@ -1,6 +1,6 @@
 /**
  * Appcelerator Titanium Mobile
- * Copyright (c) 2010-2014 by Appcelerator, Inc. All Rights Reserved.
+ * Copyright (c) 2010-2019 by Appcelerator, Inc. All Rights Reserved.
  * Licensed under the terms of the Apache Public License
  * Please see the LICENSE included with this distribution for details.
  */
@@ -129,61 +129,6 @@ - (void)setPassthroughViews:(id)args
   }
 }
 
-- (void)setWidth:(id)value
-{
-  ENSURE_SINGLE_ARG_OR_NIL(value, NSObject);
-  DebugLog(@"[WARN] Setting width on the popover directly is deprecated. Change the width property of the contentView property instead");
-
-  if (IS_NULL_OR_NIL(value)) {
-    poWidth = TiDimensionUndefined;
-  } else {
-    poWidth = TiDimensionFromObject(value);
-  }
-  [self replaceValue:value forKey:@"width" notification:NO];
-
-  if (popoverInitialized) {
-    TiThreadPerformOnMainThread(^{
-      [self updateContentSize];
-    },
-        NO);
-  }
-}
-
-- (void)setHeight:(id)value
-{
-  ENSURE_SINGLE_ARG_OR_NIL(value, NSObject);
-  DebugLog(@"[WARN] Setting height on the popover directly is deprecated. Change the height property of the contentView property instead");
-
-  if (IS_NULL_OR_NIL(value)) {
-    poHeight = TiDimensionUndefined;
-  } else {
-    poHeight = TiDimensionFromObject(value);
-  }
-  [self replaceValue:value forKey:@"height" notification:NO];
-
-  if (popoverInitialized) {
-    TiThreadPerformOnMainThread(^{
-      [self updateContentSize];
-    },
-        NO);
-  }
-}
-
-- (void)setTitle:(id)item
-{
-  DebugLog(@"[ERROR] Support for setting title on the popover directly is removed in 3.4.2");
-}
-
-- (void)setRightNavButton:(id)args
-{
-  DebugLog(@"[ERROR] Support for setting rightNavButton on the popover directly is removed in 3.4.2");
-}
-
-- (void)setLeftNavButton:(id)args
-{
-  DebugLog(@"[ERROR] Support for setting leftNavButton on the popover directly is removed in 3.4.2");
-}
-
 #pragma mark Public Methods
 
 - (void)show:(id)args