From 4122858166119d724457e9fcc4a9c28ef872f38c Mon Sep 17 00:00:00 2001 From: Gary Mathews Date: Fri, 21 Aug 2020 11:54:36 -0700 Subject: [PATCH] fix(android): remove unnecessary v8 refs (#11931) --- android/runtime/v8/src/native/NativeObject.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/android/runtime/v8/src/native/NativeObject.h b/android/runtime/v8/src/native/NativeObject.h index 8ecbdfdda35..610b32c2b0b 100644 --- a/android/runtime/v8/src/native/NativeObject.h +++ b/android/runtime/v8/src/native/NativeObject.h @@ -33,9 +33,9 @@ class NativeObject virtual ~NativeObject() { - if (persistent().IsEmpty()) + if (persistent().IsEmpty()) { return; - assert(persistent().IsNearDeath()); + } persistent().ClearWeak(); persistent().Reset(); } @@ -117,14 +117,13 @@ class NativeObject static void WeakCallback(const v8::WeakCallbackInfo& data) { NativeObject* wrap = data.GetParameter(); assert(wrap->refs_ == 0); - assert(wrap->handle_.IsNearDeath()); wrap->handle_.Reset(); delete wrap; } v8::Persistent handle_; - friend class ProxyFactory; + friend class ProxyFactory; }; }