Move most strings in the package to use vscode.l10n function #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
force-pushed
the
chore/move-strings-to-l10n
branch
from
1b20d94
to
0755a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates most strings in the package to use the
vscode.l10nfunction and adds the file generated fromnpx @vscode/l10n-dev export --outDir ./l10n ./srcto help generating for other languages.It most likely would be sensible to review and see if we can consolidate similar strings to try and avoid duplication.
I haven't touched the debugger yet as I'm not too sure how that works with pieces of it being a separate process, and haven't touched the explorer code as it requires some thinking/opinions, i.e. given that
Devicerepresents a target in titanium cli should it be localised?Marking as draft as this is entirely untested