New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling with Tideways #26

Closed
joehoyle opened this Issue Sep 12, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@joehoyle

joehoyle commented Sep 12, 2016

Is there any equivalent of xhprof_sample_enable in Tideways? Using xhprof_enable I can only get 1 level deep call stacks, which makes the data unusable for Flamegraphs and the like.

@beberlei

This comment has been minimized.

Show comment
Hide comment
@beberlei

beberlei Sep 21, 2016

Contributor

@joehoyle no, we removed this functionality, because we didn't need it ourselves and it interfered with a refactoring. Sorry :-)

Contributor

beberlei commented Sep 21, 2016

@joehoyle no, we removed this functionality, because we didn't need it ourselves and it interfered with a refactoring. Sorry :-)

@beberlei beberlei closed this Sep 21, 2016

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Sep 21, 2016

@beberlei Would you be interested in re-adding it if there was community interest in supporting it?

rmccue commented Sep 21, 2016

@beberlei Would you be interested in re-adding it if there was community interest in supporting it?

@joehoyle joehoyle referenced this issue Oct 6, 2016

Open

PHP 7 ? #2

@beberlei

This comment has been minimized.

Show comment
Hide comment
@beberlei

beberlei Mar 3, 2017

Contributor

@rmccue to be honest no, since we have removed much of the code that makes the extension dynamically switch between callgraph and sampling modes and we really don't need the flamegraph sampling mode for our own use-case. I think it makes more sense to have a dedicated extension just for flamegraph profiling, but I haven't had time to work on one yet.

Contributor

beberlei commented Mar 3, 2017

@rmccue to be honest no, since we have removed much of the code that makes the extension dynamically switch between callgraph and sampling modes and we really don't need the flamegraph sampling mode for our own use-case. I think it makes more sense to have a dedicated extension just for flamegraph profiling, but I haven't had time to work on one yet.

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Mar 4, 2017

Having dug into the code a bit (in an effort to port XHProf to PHP7 with sampling support), I agree that it's likely better as a separate extension. We're (@humanmade) quite interested in retaining sampling, so I'll investigate splitting it out into a separate extension that can work alongside the Tideways extension. :)

rmccue commented Mar 4, 2017

Having dug into the code a bit (in an effort to port XHProf to PHP7 with sampling support), I agree that it's likely better as a separate extension. We're (@humanmade) quite interested in retaining sampling, so I'll investigate splitting it out into a separate extension that can work alongside the Tideways extension. :)

@Krinkle

This comment has been minimized.

Show comment
Hide comment
@Krinkle

Krinkle Sep 28, 2017

@rmccue We ran into the same issue when evaluating Tideways for PHP 7 at Wikimedia Foundation. See https://phabricator.wikimedia.org/T176916. Curious what your ended up doing, and whether we can collaborate or find a solution together.

Krinkle commented Sep 28, 2017

@rmccue We ran into the same issue when evaluating Tideways for PHP 7 at Wikimedia Foundation. See https://phabricator.wikimedia.org/T176916. Curious what your ended up doing, and whether we can collaborate or find a solution together.

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Oct 6, 2017

@Krinkle I ended up pinging Phacility directly about XHProf, and they pushed an experimental branch for PHP 7: https://github.com/phacility/xhprof/tree/experimental

We're definitely still interested in keeping XHProf + sampling for PHP 7 in an ongoing matter, so would love to collaborate if we can. This issue probably isn't the best place to discuss that, but feel free to email ryan[at]hmn.md if you want to chat :)

rmccue commented Oct 6, 2017

@Krinkle I ended up pinging Phacility directly about XHProf, and they pushed an experimental branch for PHP 7: https://github.com/phacility/xhprof/tree/experimental

We're definitely still interested in keeping XHProf + sampling for PHP 7 in an ongoing matter, so would love to collaborate if we can. This issue probably isn't the best place to discuss that, but feel free to email ryan[at]hmn.md if you want to chat :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment