Update glance to correctly function on lm models with a 0 intercept#1209
Merged
simonpcouch merged 4 commits intotidymodels:mainfrom Sep 26, 2024
Merged
Update glance to correctly function on lm models with a 0 intercept#1209simonpcouch merged 4 commits intotidymodels:mainfrom
glance to correctly function on lm models with a 0 intercept#1209simonpcouch merged 4 commits intotidymodels:mainfrom
Conversation
Collaborator
|
Thanks for the thorough issue description! These changes look clean—just added a NEWS bullet and will pick this up in the morning once checks have run. |
|
This pull request has been automatically locked. If you believe the issue addressed here persists, please file a new PR (with a reprex: https://reprex.tidyverse.org) and link to this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response to issue: #1208
Have implemented fix, & associated tests and function works as intended.