New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods for `survdiff` objects #147

Merged
merged 5 commits into from Nov 19, 2017

Conversation

Projects
None yet
2 participants
@mbojan
Contributor

mbojan commented Jul 12, 2016

As issue'd #145 . I have only ran tests in test-survdiff.R, mainly because of #146 .

@dgrtwo

This comment has been minimized.

Collaborator

dgrtwo commented Jul 12, 2016

Nice, thank you!

I'll merge once you or I have finished out the TODO in the docs.

@mbojan

This comment has been minimized.

Contributor

mbojan commented Jul 13, 2016

Heh, sorry. I'll fix the TODOs. :) Developer's haste.

@mbojan

This comment has been minimized.

Contributor

mbojan commented Jul 13, 2016

Done. Seems to pass the check with --no-tests (for some reason I am not able to install rstanarm) and the tests in test-survdiff.R.

@mbojan mbojan force-pushed the mbojan:survdiff branch from b950540 to 81132f2 Feb 7, 2017

@mbojan

This comment has been minimized.

Contributor

mbojan commented Feb 7, 2017

I have rebased against current master. The CI seem to fail because of faulty examples of tidy.orcutt. Running RCMD check on my machine (skipping some of the dependencies) completes OK.

@dgrtwo dgrtwo merged commit 6c7bc02 into tidymodels:master Nov 19, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment