New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boot_tidiers.R to fix confidence interval output #167

Merged
merged 1 commit into from Nov 19, 2017

Conversation

Projects
None yet
3 participants
@jbiesanz
Contributor

jbiesanz commented Oct 18, 2016

The confidence interval output summary (ci.tab) was transposed and the function would fail if one was bootstrapping any number of statistics other than exactly 2 (and that output was incorrectly located in the resulting data.frame). Transposing the ci.tab matrix fixes this error.

There also was an "Error: unexpected 'else' " in the middle of the function that is corrected.

Update boot_tidiers.R to fix confidence interval output
The confidence interval output summary (ci.tab) was transposed and the function would fail if one was bootstrapping any number of statistics other than exactly 2 (and that output was incorrectly located in the resulting data.frame). Transposing the ci.tab matrix fixes this error.

There also was an "Error: unexpected 'else' " in the middle of the function that is corrected.
@janfreyberg

This comment has been minimized.

janfreyberg commented Aug 6, 2017

+1, this should be merged ASAP

@dgrtwo dgrtwo merged commit c0f02c3 into tidymodels:master Nov 19, 2017

2 of 3 checks passed

codecov/patch 0.00% of diff hit (target 28.31%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dgrtwo

This comment has been minimized.

Collaborator

dgrtwo commented Nov 19, 2017

Thanks! Sorry this took a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment