New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgdown site for broom #260

Merged
merged 2 commits into from Jun 4, 2018

Conversation

Projects
None yet
4 participants
@jayhesselberth
Contributor

jayhesselberth commented Nov 19, 2017

broom needs a pkgdown site!

Preview at https://vigilant-goldberg-0fd2e5.netlify.com/

  • add the broom logo as logo.png in man/figures and re-run pkgdown::build_site()
  • create docs/CNAME with single line containingbroom.tidyverse.org
  • In Settings / Github Pages / Source choose "master branch /docs folder"

The current Reference page has a lot of redundant entries because of the extensive use of S3 in broom (see r-lib/pkgdown#436).

@jayhesselberth

This comment has been minimized.

Contributor

jayhesselberth commented Nov 19, 2017

closes #238, closes #272

@topepo

This comment has been minimized.

Contributor

topepo commented Nov 20, 2017

You might consider using DT for the long table (or put it in an article)

@alexpghayes alexpghayes merged commit 3c8c114 into tidymodels:master Jun 4, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 4d0e9fb...c394572
Details
codecov/project 40.82% remains the same compared to 4d0e9fb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 4, 2018

Thanks!

@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 4, 2018

@batpigandme I don't have access to the repo settings. Can you set up the Github pages?

@batpigandme

This comment has been minimized.

Contributor

batpigandme commented Jun 4, 2018

@alexpghayes 10-4, I'm separated from my laptop rn, but I'll be on it once we're ruinited (my laptop and I) later tonight or AM. 👍

@batpigandme

This comment has been minimized.

Contributor

batpigandme commented Jun 5, 2018

Oh, shoot do you mean on netlify, @alexpghayes? If so, I don't have access to that either…

Disregard, should be good.

@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 5, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment