Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add labels to prcomp object before tidying #265
Looks good. Would you add a quick test to make sure that the reprex from before:
library(broom) test <- as.data.frame(matrix(1:9, ncol = 3) + rnorm(n = 9, sd = 0.25)) test #> V1 V2 V3 #> 1 0.7707063 3.870905 7.091106 #> 2 2.3385348 4.987070 7.835155 #> 3 2.6638938 6.006691 8.690749 pca <- prcomp(test) tidy(pca, matrix = "u") #> Error in data.frame(label = rep(labels, times = ncomp), samples): arguments imply differing number of rows: 0, 9 test2
doesn't give an error?
Jun 6, 2018
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.