New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `psych` dependency from data frame tidiers #313

Merged
merged 2 commits into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@nutterb
Contributor

nutterb commented Jun 4, 2018

  • Revamps the tidy.data.frame method to directly calculate the metrics previously calculated by psych.
  • Removes psych package from the Imports in DESCRIPTION.
  • I'm not completely clear on the protocol here, but I pretty blatantly borrowed from the moments package to get calculations for skew and kurtosis. I've added that source to the references in the documentation for tidy.data.frame and added the authors of moments to the authorship list in DESCRIPTION.

See Issue #296

nutterb added some commits Jun 4, 2018

@alexpghayes alexpghayes merged commit 99bf382 into tidymodels:master Jun 4, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 4, 2018

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment