Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove psych dependency from data frame tidiers #313

Merged
merged 2 commits into from
Jun 4, 2018

Conversation

nutterb
Copy link
Contributor

@nutterb nutterb commented Jun 4, 2018

  • Revamps the tidy.data.frame method to directly calculate the metrics previously calculated by psych.
  • Removes psych package from the Imports in DESCRIPTION.
  • I'm not completely clear on the protocol here, but I pretty blatantly borrowed from the moments package to get calculations for skew and kurtosis. I've added that source to the references in the documentation for tidy.data.frame and added the authors of moments to the authorship list in DESCRIPTION.

See Issue #296

@alexpghayes alexpghayes merged commit 99bf382 into tidymodels:master Jun 4, 2018
@alexpghayes
Copy link
Collaborator

Awesome. Thanks!

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants