Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy implementation for tseries::garch #323

Merged
merged 6 commits into from Jun 7, 2018

Conversation

wilsonfreitas
Copy link
Contributor

The implementation of the tidy methods, tidy, glance and augment, for the garch class of tseries package.

The implementation of the tidy methods, tidy, glance and augment, for the garch class of tseries package.
@alexpghayes
Copy link
Collaborator

It looks like an example that loads the entire tidyverse (which isn't listed in Suggested) is causing the build error. I would try to use just the packages you need in the example, and then make sure that R CMD check passes locally.

Let me know if you need any help!

@wilsonfreitas
Copy link
Contributor Author

I am trying to run check but it is returning the following error

Error in UseMethod("as.quoted") : 
  no applicable method for 'as.quoted' applied to an object of class "quosures"

while evaluates the code below in bootstraping.Rmd vignette.

ggplot(boot_coefs, aes(estimate)) + 
    geom_histogram(binwidth = 2) + 
    facet_wrap(facets = vars(term), scales = "free")

I guess it is being caused by vars(term) and I've already updated rlang (version 0.2.1).
I can't figure out what is going on.
any clue?

@alexpghayes
Copy link
Collaborator

It's building for me locally, and your AppVeyor build passed, which is promising. Maybe try updating your packages?

I just added a commit to use tidyverse style and return tibbles. If that passes the AppVeyor I'll merge. I also added you as a contributor.

@alexpghayes alexpghayes merged commit 8ffd412 into tidymodels:master Jun 7, 2018
@alexpghayes
Copy link
Collaborator

Thank you so much!

@wilsonfreitas
Copy link
Contributor Author

Great @alexpghayes! This is awesome.

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants