New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tidiers for car::durbinWatsonTest objects #341

Merged
merged 5 commits into from Jun 9, 2018

Conversation

Projects
None yet
2 participants
@mkuehn10
Contributor

mkuehn10 commented Jun 9, 2018

Trying to resolve #266

@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 9, 2018

You need to add car to Suggests in DESCRIPTION. Probably the best way to do this is with the usethis package: usethis::use_package("car", type = "Suggests") I believe. Then you'll want to use library(car) in the test file, or refer to the test function with a car:: prefix.

Does that help?

@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 9, 2018

Also I think it would be best to just implement a glance method, and no tidy. tidy is meant to be used on model components, but here we can only really summarize the whole model, so glance is the way to go.

@mkuehn10

This comment has been minimized.

Contributor

mkuehn10 commented Jun 9, 2018

I noticed that the htest tidiers make the tidy and glance the same, so that's what I did for this one as well.

@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 9, 2018

Okay, that's fine then!

@alexpghayes alexpghayes merged commit c5e574f into tidymodels:master Jun 9, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

karldw added a commit to karldw/broom that referenced this pull request Jun 10, 2018

@mkuehn10

This comment has been minimized.

Contributor

mkuehn10 commented Jun 11, 2018

@karldw I think this resolves #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment