New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit rows with all NA in confint_tidy() #345

Merged
merged 4 commits into from Jun 14, 2018

Conversation

Projects
None yet
2 participants
@atyre2
Contributor

atyre2 commented Jun 10, 2018

Following the discussion at #324, I re-ran all the problematic examples and as far as I can tell they all work as intended (omitting NA rows). The exception is confint_tidy(). I tried adding the same code for rank-deficient models from process_lm(), but some tidiers call confint_tidy() with objects that are not regression models, and therefore lack components like rank and qr (e.g. bbmle). So instead I checked for NA rows in the result, and eliminate those.

The only issue I can see is that there is no way to tell which rows were eliminated, because confint_tidy() just returns two columns with the confidence intervals. This is quite different from other tidy() results which always include the names of the relevant terms.

alexpghayes added some commits Jun 14, 2018

@alexpghayes alexpghayes merged commit 6f24ba1 into tidymodels:master Jun 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment