Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upuse ldply instead of lapply to tidy aovlist's #377
Conversation
mvevans89
added some commits
Jun 14, 2018
alexpghayes
reviewed
Jun 15, 2018
Thanks so much for this PR! I made a couple comments on the code, but this looks great overall.
| function(a) dplyr::mutate(ret[[a]], stratum = a) | ||
| ) | ||
| ret <- do.call("rbind", ret) | ||
| ret <- plyr::ldply(x, tidy, .id = "stratum") |
This comment has been minimized.
This comment has been minimized.
alexpghayes
Jun 15, 2018
Collaborator
We're looking to move away from plyr at the moment. Would you be willing to use purrr here instead?
This comment has been minimized.
This comment has been minimized.
| #' | ||
| #' @importFrom plyr ldply | ||
| #' | ||
| #' @import dplyr |
This comment has been minimized.
This comment has been minimized.
alexpghayes
Jun 15, 2018
Collaborator
dplyr and plyr get imported package-wide in DESCRIPTION, so I believe these aren't necessary.
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,15 @@ | ||
| context("anova tidiers") |
This comment has been minimized.
This comment has been minimized.
| test_that("tidy.aovlist works"){ | ||
| aovlistfit <- aov(mpg ~ wt + disp + Error(drat), mtcars) | ||
| td <- suppressWarnings(tidy(aovlistfit)) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mvevans89
Jun 15, 2018
Contributor
I checked and there actually are none. Warning suppression was just a hold over from copying the format of the test-lm.R. I'll take it out
This comment has been minimized.
This comment has been minimized.
|
Don't worry about the build failure at the moment, BTW, that's my fault and I need to fix it. |
This comment has been minimized.
This comment has been minimized.
|
Changes look good. Will merge as soon as I sort out the |
alexpghayes
added some commits
Jun 18, 2018
mvevans89
requested a review
from
dgrtwo
as a
code owner
Jun 18, 2018
alexpghayes
added some commits
Jun 18, 2018
This comment has been minimized.
This comment has been minimized.
|
Okay, think we're good to merge. Feel free to add yourself as a contributor to |
mvevans89 commentedJun 15, 2018
this changes the way tidy is used to tidy aovlist's (such as within-subject error structures) to close issue #299