New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing suggestions to new-tidiers vignette #397

Merged
merged 2 commits into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@karldw
Contributor

karldw commented Jun 21, 2018

Replaces #339

@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 21, 2018

Looks great, thanks for writing this up and also your patience. Would you add yourself as a contributor in DESCRIPTION and then I'll merge?

@karldw

This comment has been minimized.

Contributor

karldw commented Jun 21, 2018

No problem! Sorry to push such a bad rebase last time around.

@alexpghayes alexpghayes merged commit 8531d1d into tidymodels:master Jun 21, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexpghayes

This comment has been minimized.

Collaborator

alexpghayes commented Jun 21, 2018

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment