Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing suggestions to new-tidiers vignette #397

Merged
merged 2 commits into from Jun 21, 2018
Merged

Add testing suggestions to new-tidiers vignette #397

merged 2 commits into from Jun 21, 2018

Conversation

karldw
Copy link
Contributor

@karldw karldw commented Jun 21, 2018

Replaces #339

@alexpghayes
Copy link
Collaborator

alexpghayes commented Jun 21, 2018

Looks great, thanks for writing this up and also your patience. Would you add yourself as a contributor in DESCRIPTION and then I'll merge?

@karldw
Copy link
Contributor Author

karldw commented Jun 21, 2018

No problem! Sorry to push such a bad rebase last time around.

@alexpghayes alexpghayes merged commit 8531d1d into tidymodels:master Jun 21, 2018
@alexpghayes
Copy link
Collaborator

Awesome!

@karldw karldw deleted the tests-docs branch Apr 11, 2019
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants