Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace colnames with names in tidy.polr (#497) #498

merged 2 commits into from Oct 1, 2018


Copy link

@haozhu233 haozhu233 commented Sep 10, 2018

Trying to fix #497

Copy link

Thanks for the PR! Would you mind adding a quick test and adding the bugfix to NEWS and then I'll merge?

Copy link
Contributor Author

@alexpghayes I just added NEWs and test cases and I made some changes to how I fixed this. The main problem is that when there is only one numeric x, stats::confint() returns a vector instead of a matrix.

@alexpghayes alexpghayes merged commit 411e544 into tidymodels:master Oct 1, 2018
Copy link

Thanks for taking this on!

Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

tidy.polr throws bug when = T
2 participants