Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to dev tibble #536

Merged
merged 2 commits into from Nov 24, 2018

Conversation

@jennybc
Copy link
Contributor

commented Nov 22, 2018

Resuming #534 here.

sp-tidiers main theme: apply column names before coercing to tibble

lavaan-tiders: use enframe(), which is unambiguously requesting a column, instead of as_tibble() on a vector

base tidiers: I gather these are on the path to deprecation / removal, since they are basically just as_tibble(). So I altered your tests and examples enough that you aren't testing our edge cases. I also coerce ftable objects to table so we only have to worry about one thing.

@jennybc jennybc referenced this pull request Nov 22, 2018

@jennybc jennybc force-pushed the jennybc:dev-tibble branch from e8b581a to 3f61b3b Nov 22, 2018

@jennybc

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

I rebased this and cherry-picked the AppVeyor fix. Maybe now we can get good data from CI.

@alexpghayes alexpghayes merged commit e1bd582 into tidymodels:0.5.1 Nov 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.