Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to dev tibble #536

Merged
merged 2 commits into from Nov 24, 2018
Merged

Adapt to dev tibble #536

merged 2 commits into from Nov 24, 2018

Conversation

@jennybc
Copy link
Contributor

@jennybc jennybc commented Nov 22, 2018

Resuming #534 here.

sp-tidiers main theme: apply column names before coercing to tibble

lavaan-tiders: use enframe(), which is unambiguously requesting a column, instead of as_tibble() on a vector

base tidiers: I gather these are on the path to deprecation / removal, since they are basically just as_tibble(). So I altered your tests and examples enough that you aren't testing our edge cases. I also coerce ftable objects to table so we only have to worry about one thing.

@jennybc jennybc mentioned this pull request Nov 22, 2018
@jennybc
Copy link
Contributor Author

@jennybc jennybc commented Nov 22, 2018

I rebased this and cherry-picked the AppVeyor fix. Maybe now we can get good data from CI.

Loading

@alexpghayes alexpghayes merged commit e1bd582 into tidymodels:0.5.1 Nov 24, 2018
2 checks passed
Loading
@github-actions
Copy link

@github-actions github-actions bot commented Mar 10, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

Loading

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants