Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tidiers for drc #574

Merged
merged 10 commits into from Apr 8, 2019
Merged

Added tidiers for drc #574

merged 10 commits into from Apr 8, 2019

Conversation

EDiLD
Copy link
Contributor

@EDiLD EDiLD commented Jan 6, 2019

Added tidiers for drc, which provides a big variety of dose-response-models.

Example:

 library(drc)
 mod <- drm(dead/total~conc, type, 
    weights = total, data = selenium, fct = LL.2(), type = "binomial")
 mod
 
 tidy(mod)
 tidy(mod, conf.int = TRUE)
 tidy(mod, quick = TRUE)

 glance(mod)

I really had to fight with the tests for augment(), but I could not get them pass :(. Code is in here, but uncommented. If someone more experienced with broom might want to look into it.

Failing tests are unrelated to this PR.

@alexpghayes
Copy link
Collaborator

Thanks! I'll take a look at the augment method in a couple days!

@EDiLD
Copy link
Contributor Author

EDiLD commented Jan 8, 2019

Problem, is that I had this code hanging around for >2 years. In the meantime broom grew and developed much further and I could not pick up the latest changes (though I read the documentation).

@EDiLD
Copy link
Contributor Author

EDiLD commented Jan 15, 2019

@alexpghayes I fixed also the augment.drc() part - so no need for you to check.
I still need make a small fix to modeltest, before this ready

@EDiLD
Copy link
Contributor Author

EDiLD commented Jan 16, 2019

@alexpghayes If you have any suggestions/comments we could have also a chat in person at rstudio::conf (I am participating in the ML workshop).

@EDiLD
Copy link
Contributor Author

EDiLD commented Jan 16, 2019

Getting some

Arguments conf.int, conf.level to augment.drc must be listed in the argument glossary.

errors, when testing. Although I do inline definition of columns

return_augment(".conf.low" = "Lower Confidence Interval",
[snip]

Any idea?

@alexpghayes
Copy link
Collaborator

alexpghayes commented Jan 16, 2019 via email

@alexpghayes
Copy link
Collaborator

I'm sorry that I haven't look at this yet. I'll try to give this a thorough review over the weekend!

@alexpghayes
Copy link
Collaborator

I'm sorry for the delay on this! I'm going to go ahead and merge and poke through the code as I have time!

@alexpghayes alexpghayes merged commit 63c3b9f into tidymodels:master Apr 8, 2019
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants