Finish off #490 #630
Merged
Finish off #490 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For one-dimensional models, return the mean for each component in one column. For one-dimensional models, the previous code was returning the mean of each component in different columns, and all of them reported in the row corresponding to the last component, while the values for the other rows were filled filled with NAs. Now, if the model is one-dimensional, the mean for each component is stored in a column vector, which is added to the final table `ret` as a new column named `mean`.
The case of giving a one-dimensional vector to `Mclust()` was missing.
The previous fix was leading to an error if we only asked for one component when calling `Mclust()`.
`augment.Mclust()` gives an error if the data stored in the object returned by `Mclust()` is a vector.
…balina-patch-1
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.