Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatialreg #847

Merged
merged 108 commits into from Jun 8, 2020
Merged

Spatialreg #847

merged 108 commits into from Jun 8, 2020

Conversation

gregmacfarlane
Copy link
Contributor

@gregmacfarlane gregmacfarlane commented May 12, 2020

This adds documented methods for spatial autoregressive models of classsarlm estimated with the spatialreg package. Begins from code supplied to #841, with some adjustments for style and adding confidence interval on estimates.

grantmcdermott and others added 30 commits Aug 27, 2019
Retain SEs of any fixest input, including fixest summary
- Adjustments to tidying fixest summaries
- Make `glance.fixest` results depend on the type of model estimated.
- Clarify that augment only works on `feols`, `feglm` or `femlm` models
Also simplify tidy.mfx() using fix_data_frame()
- Break out detection of fixest summary
- Add some documentation about optional arguments and which types of models
  `augment.fixest` can handle.
R/spdep-tidiers.R Show resolved Hide resolved
#' @export
#' @seealso [augment()]
#' @family spatialreg tidiers
augment.sarlm <- function(x) {
Copy link
Collaborator

@simonpcouch simonpcouch Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a ... argument here for compatibility with the generic and @template param_unused_dots roxygen tag?

simonpcouch and others added 7 commits Jun 5, 2020
I I like you udoated my function. If it is ok I extended your script for another model suppoerted
We don't actually need a three-level if() statement. We can simply append if the value exists, and skip if it doesn't. This allows for much simpler code
@simonpcouch simonpcouch merged commit fb0c6eb into tidymodels:master Jun 8, 2020
@simonpcouch
Copy link
Collaborator

simonpcouch commented Jun 8, 2020

Merged! Thanks.🙂

simonpcouch added a commit that referenced this pull request Jun 8, 2020
@petrhrobar
Copy link
Contributor

petrhrobar commented Jun 8, 2020

Cool! Thank you for your work.

@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants