Repository navigation
add butcher methods for dbarts::bart() - #240
Merged
Merged
Conversation
This was referenced Dec 22, 2022
juliasilge
approved these changes
Jan 11, 2023
juliasilge
left a comment
Member
There was a problem hiding this comment.
This looks great! Thank you so much 🙌
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #234. I haven't added a NEWS entry, as I anticipate putting in a few of these PRs today, and don't want to introduce merge conflicts for you!
Unfortunately, the "heaviest" entry by far,
$fit, is required for prediction.😫 That slot is only occupied whenkeeptrees = TRUE, which is not a default.Created on 2022-12-22 with reprex v2.0.2