add butcher methods for mixOmics output - #249
Merged
Merged
Conversation
9 tasks
Member
|
Do you think it would be worth it to install the package into the check action, so the tests get run on CI? Or not very worthwhile? |
Contributor
Author
|
I think that's a good idea. :) Added in 0d607c5. EDIT: Seeing those failures, trying to debug🤔 |
juliasilge
approved these changes
Jan 25, 2023
juliasilge
left a comment
Member
There was a problem hiding this comment.
This is great -- thank you again! 👨🎤
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods do a good job of being selective about what they bring along from the enclosing env, and do make use of most all of the heavier bits of inputted data that they retain at predict time—not a lot of memory released, in the end.
mixo_plsdaobjects are a subclass ofmixo_pls, so don’t need their own methods!The mixOmics package is hosted on Bioconductor rather than CRAN, so this PR doesn’t introduce mixOmics as a dependency. This also means that mixOmics methods won’t be tested on CRAN or CI.
Created on 2023-01-23 with reprex v2.0.2
Related to #234.