Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to testthat e3 #142

Merged
merged 24 commits into from Jan 18, 2022
Merged

Move to testthat e3 #142

merged 24 commits into from Jan 18, 2022

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Jan 13, 2022

Closes #132

  • removed context() and other deprecated functions
  • uses snaphot tests
  • removed un-used helper objects and helper functions
  • made tests more self-contained by namespacing functions and moving some model fitting into the test_that() calls

hfrick added 23 commits Jan 11, 2022
@hfrick
require testthat e3
9655a3c
@hfrick
remove usage of context()
68bcb48
@hfrick
update arg name from tol to tolerance
20d4a4d
@hfrick
removed usage of expect_equivalent()
974368b
@hfrick
replace expect_output() with expect_snapshot()
1205bea
@hfrick
update environments
b9e1b7c 
- `quo()` uses an empty environment already
- tagging args with `varying()` captures the same environment
@hfrick
no need anymore for helper function new_empty_quosure()
c5bebb2
@hfrick
snapshot multiple warnings
0cd2356
@hfrick
different env are okay
a1e861e
@hfrick
update test-bag_tree-rpart.R
6fe300c 
- only test error-free model fit once
- namespace functions
- move model fit into test_that() because it doesn't take long
@hfrick
update test-boost_tree-mboost.R
b09ade4 
- don't test environments
- namespace functions
- make self-contained
- only test once that fit is error-free
@hfrick
update test-decision_tree-party.R
5df1b9c 
- ignore envs in model object comparison
- only test model fitting once
- make tests self-contained
@hfrick
update test-decision_tree-rpart.R
3b9e3fa
@hfrick
update test-proportional_hazards-glmnet.R
466ee93
@hfrick
update test-proportional_hazards-survival.R
a0e548a
@hfrick
update test-rand_forest-party.R
813831f
@hfrick
update test-survival_reg.R
254add4
@hfrick
go back to simpler expectation
7fda679 
we just want to make sure it's a parsnip model object
@hfrick
update test-survival_reg-survival.R
4129f1f
@hfrick
update test-survival_reg-survival.R
08e8c6b
@hfrick
clean up unused objects
b6cc732
@hfrick
quiet warning
eb19a72
@hfrick
modify reference value and add code for generating it
9fce789
@hfrick hfrick added this to In progress in v1.0.0 Jan 13, 2022
@hfrick hfrick requested a review from DavisVaughan Jan 13, 2022
DavisVaughan
DavisVaughan requested changes Jan 18, 2022
View changes
tests/testthat/test-decision_tree-rpart.R Show resolved Hide resolved
inst/helper-objects-for-testing.R Show resolved Hide resolved
v1.0.0 automation moved this from In progress to Review in progress Jan 18, 2022
@hfrick hfrick requested a review from DavisVaughan Jan 18, 2022
v1.0.0 automation moved this from Review in progress to Reviewer approved Jan 18, 2022
@hfrick hfrick merged commit 1a02ab1 into main Jan 18, 2022
8 checks passed
v1.0.0 automation moved this from Reviewer approved to Done Jan 18, 2022
@hfrick hfrick deleted the testthat-e3 branch Jan 18, 2022
@github-actions
Copy link

@github-actions github-actions bot commented Feb 2, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DavisVaughan DavisVaughan

Assignees
No one assigned
Labels
None yet
Projects
v1.0.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to testthat e3
2 participants
@hfrick @DavisVaughan