Skip to content

File reorg #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 11, 2022
Merged

File reorg #206

merged 8 commits into from
Aug 11, 2022

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Aug 11, 2022

Reorganizing files 🎉

Goals:

  • be able to relatively easily find stuff!
  • be able to test more easily via devtools:::test_active_file()

What new?

  • more <model_type>-<engine>.R files which collect engine-specific code
  • more alignment in file names between files in R/ and tests/testthat/

Leaving R/partykit.R untouched for the moment because I need to go over the calculation of the survival probabilities and want to do trees and forests together.

hfrick added 8 commits August 11, 2022 12:07
* move print method up
* add `survival_time_coxnet()` from `aaa_survival_prop.R`
* add `survival_prob_coxnet()` from `aaa_survival_prop.R`
(probabilty, not proportion)
* no changes due to new roxygen2 version
* only updates where the source of `.Rd` files can be found
@hfrick hfrick merged commit 900c9dd into main Aug 11, 2022
@hfrick hfrick deleted the file-reorg branch August 11, 2022 14:15
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant