Improve error messages #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191
This PR improves error messages for/from
cph_survival_pre()check_strata_nterms(),check_intercept_model(), andcheck_dots_coxnet()coxnet_train()by passing the call and
newdatafrom the glmnet predict methods since it now gets called inparsnip::predict.model_fit()which is called nextnewdataerror in themulti_predict()method for coxnet model to the wording now used in parsnip