Skip to content

Conversation

@hfrick
Copy link
Member

@hfrick hfrick commented Apr 6, 2023

Closes #191

This PR improves error messages for/from

  • the survival helper cph_survival_pre()
  • the glmnet check functions check_strata_nterms(), check_intercept_model(), and check_dots_coxnet()
  • the glmnet fit wrapper coxnet_train()

by passing the call and

  • removes the error for newdata from the glmnet predict methods since it now gets called in parsnip::predict.model_fit() which is called next
  • updates the wording of the newdata error in the multi_predict() method for coxnet model to the wording now used in parsnip

@hfrick hfrick marked this pull request as ready for review April 6, 2023 17:05
@hfrick hfrick merged commit 917ffb8 into main Apr 11, 2023
@hfrick hfrick deleted the errors-update branch April 11, 2023 10:38
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error handling

2 participants