Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do grid_latin_hypercube and grid_max_entropy return object of only class tibble? #100

Closed
cimentadaj opened this issue Feb 17, 2020 · 2 comments

Comments

@cimentadaj
Copy link

cimentadaj commented Feb 17, 2020

The problem

I'm having trouble understanding why grid_latin_hypercube and grid_max_entropy only return objects of class tibble (and data frame, etc..) when grid_regular and grid_random return objects with custom classes of param_grid. I'm planing to create methods for tuning grids and I stumbled into this. Is this a design choice?

Have you considered adding a custom class to these two tuning grids as well?

Reproducible example

library(dials)
#> Loading required package: scales
class(grid_latin_hypercube(penalty(), mixture()))
#> [1] "tbl_df"     "tbl"        "data.frame"
class(grid_max_entropy(penalty(), mixture()))
#> [1] "tbl_df"     "tbl"        "data.frame"

# Whereas grid_regular and grid_random do have
class(grid_random(penalty(), mixture()))
#> [1] "grid_random" "param_grid"  "tbl_df"      "tbl"         "data.frame"
class(grid_regular(penalty(), mixture()))
#> [1] "grid_regular" "param_grid"   "tbl_df"       "tbl"          "data.frame"
@topepo topepo transferred this issue from tidymodels/tune Feb 24, 2020
@topepo topepo closed this as completed in 611260d Feb 24, 2020
@topepo
Copy link
Member

topepo commented Feb 24, 2020

It was an oversight; corrected in 611260d

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants