-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename margin and deprecate #85
Labels
tidy-dev-day 🤓
Tidyverse Developer Day rstd.io/tidy-dev-day
Comments
Working on this with @gralgomez |
TO DO:
|
gabrielodom
pushed a commit
to gabrielodom/dials
that referenced
this issue
Jan 31, 2020
gabrielodom
pushed a commit
to gabrielodom/dials
that referenced
this issue
Jan 31, 2020
Closed by #91 |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The dials parameter
margin()
has the same name as other R functions (including one inggplot2
).Let's make a copy called
svm_margin()
and add a warning whenmargin()
is called that tells them that it is deprecated and will be removed in the next version (plus a test case for this similar to this.The text was updated successfully, but these errors were encountered: