Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename margin and deprecate #85

Closed
topepo opened this issue Jan 9, 2020 · 4 comments
Closed

rename margin and deprecate #85

topepo opened this issue Jan 9, 2020 · 4 comments
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@topepo
Copy link
Member

topepo commented Jan 9, 2020

The dials parameter margin() has the same name as other R functions (including one in ggplot2).

Let's make a copy called svm_margin() and add a warning when margin() is called that tells them that it is deprecated and will be removed in the next version (plus a test case for this similar to this.

@topepo topepo added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jan 9, 2020
@gabrielodom
Copy link
Contributor

gabrielodom commented Jan 31, 2020

Working on this with @gralgomez

@gabrielodom
Copy link
Contributor

gabrielodom commented Jan 31, 2020

TO DO:

  • Create a copy of margin() in param_svm.R named svm_margin().
  • Add a deprecation warning to margin()
  • Add test for svm_margin() to testthat/test_parameters.R
  • Update test for margin() in testthat/test_parameters.R to expect deprecation warning
  • Add test for margin() in testthat/test_deprecate.R to check for deprecation warning
  • Update point in NEWS

gabrielodom pushed a commit to gabrielodom/dials that referenced this issue Jan 31, 2020
DavisVaughan pushed a commit that referenced this issue Jan 31, 2020
* replacement and deprecation of margins()

* Minor test changes per issue #85 and pull request 91

* updated warning to lifecycle warning; updated tests to match (per Issue #85)
@DavisVaughan
Copy link
Member

DavisVaughan commented Jan 31, 2020

Closed by #91

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

No branches or pull requests

3 participants