Added callbacks option in embed_control #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other change: created embedding variables have predictor role
klahrich
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 88.16% 88.22% +0.05%
==========================================
Files 4 4
Lines 448 450 +2
==========================================
+ Hits 395 397 +2
Misses 53 53
Continue to review full report at Codecov.
|
|
Once #10 is merged, update from master, and try running the travis checks again (I think that this should fix it) |
|
The travis failure is related to Stan needing a more modern compiler than this travis setup has. I'm fixing that in another PR today. Thanks! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly for early stopping callback
Other change: embedding variables created by step_embed have "predictor" role instead of NA