New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of `set_params()` #165

Closed
echasnovski opened this Issue Jul 29, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@echasnovski
Copy link
Collaborator

echasnovski commented Jul 29, 2018

As of b637bbd function set_params() is documented using roxygen comments but is not exported. As a result, it is listed in package index after installation. This feels like a documentation conflict. Should set_params() be documented without help page (by adding #' @noRd roxygen comment) or should it be exported?

@ismayc

This comment has been minimized.

Copy link
Collaborator

ismayc commented Jul 29, 2018

I don't think it should be exported as it is only really useful internally.

echasnovski added a commit to echasnovski/infer that referenced this issue Jul 30, 2018

ismayc added a commit that referenced this issue Aug 3, 2018

@echasnovski echasnovski closed this Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment