Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use {vdiffr} for plot testing #221

Merged
merged 1 commit into from Feb 5, 2019
Merged

Use {vdiffr} for plot testing #221

merged 1 commit into from Feb 5, 2019

Conversation

@echasnovski
Copy link
Collaborator

echasnovski commented Feb 3, 2019

This PR is about #212: using {vdiffr} in plot testing. I added expect_doppelganger() from {vdiffr} package to every meaningful plot test. This resulted into 50 examples of plotting behavior, which
are stored in 'tests/figs/visualize'.

Notes:

  • General workflow of plot testing is now as follows: call vdiffr::manage_cases() to see possible
    differences between saved (named "Before") and new (named "After") plots, choose which one should be "approved" and only then proceed with testing and checking.
  • Testing time of 'test-visualize.R' increased dramatically: from ~2.5s to ~10.9s on my machine. This might be a good indicator to revisit those tests to remove possibly unnecessary ones.
  • This code throws an uncaptured warning which doesn't affect R CMD CHECK. For now I don't really understand why this is happening.
@echasnovski echasnovski requested review from andrewpbray and ismayc Feb 3, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #221 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #221   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           13     13           
  Lines         1101   1101           
======================================
  Hits          1101   1101
@ismayc

This comment has been minimized.

Copy link
Collaborator

ismayc commented Feb 5, 2019

Great stuff! Thanks!

@ismayc ismayc merged commit 71b5ee4 into tidymodels:develop Feb 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@echasnovski echasnovski deleted the echasnovski:vdiffr branch Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.