Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `shade_confidence_interval()` #234

Merged
merged 4 commits into from May 1, 2019
Merged

Update `shade_confidence_interval()` #234

merged 4 commits into from May 1, 2019

Conversation

@echasnovski
Copy link
Collaborator

echasnovski commented Apr 28, 2019

This PR closes #230.
As a side effect, I moved all code and tests for shade_confidence_interval() and shade_ci() to separate files.

@echasnovski echasnovski requested a review from andrewpbray Apr 28, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 28, 2019

Codecov Report

Merging #234 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #234   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           14     15    +1     
  Lines         1155   1163    +8     
======================================
+ Hits          1155   1163    +8
Impacted Files Coverage Δ
R/visualize.R 100% <ø> (ø) ⬆️
R/shade_confidence_interval.R 100% <100%> (ø)
@andrewpbray andrewpbray merged commit bb75b3a into develop May 1, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@andrewpbray

This comment has been minimized.

Copy link
Collaborator

andrewpbray commented May 1, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.