Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodness of fit #241

Merged
merged 37 commits into from Aug 18, 2019

Conversation

@andrewpbray
Copy link
Collaborator

andrewpbray commented Aug 12, 2019

This adds the goodness of fit test but refactors the wrapper functions as a result. Fixes #228

andrewpbray added 30 commits Apr 2, 2019
@andrewpbray

This comment has been minimized.

Copy link
Collaborator Author

andrewpbray commented Aug 12, 2019

Looks like we're running into problems with vdiffr again. Hmm... I don't have any failures when I run the check locally and I've committed all of the new SVGs.

I'll keep tinkering with this, but if anyone spots the problem, please let me know.

@richierocks

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 18, 2019

Codecov Report

Merging #241 into develop will decrease coverage by 1.59%.
The diff coverage is 89.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #241     +/-   ##
=========================================
- Coverage      100%   98.4%   -1.6%     
=========================================
  Files           15      15             
  Lines         1163    1067     -96     
=========================================
- Hits          1163    1050    -113     
- Misses           0      17     +17
Impacted Files Coverage Δ
R/utils.R 100% <ø> (ø) ⬆️
R/specify.R 98.73% <100%> (-1.27%) ⬇️
R/wrappers.R 85.84% <84.94%> (-14.16%) ⬇️
R/generate.R 100% <0%> (ø) ⬆️
R/get_p_value.R 100% <0%> (ø) ⬆️
R/hypothesize.R 100% <0%> (ø) ⬆️
R/shade_p_value.R 100% <0%> (ø) ⬆️
R/deprecated.R 100% <0%> (ø) ⬆️
... and 8 more
@andrewpbray andrewpbray merged commit 8738090 into develop Aug 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@andrewpbray andrewpbray deleted the goodness-of-fit branch Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.