Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export rep_sample_n() #82

Merged
merged 7 commits into from Jan 12, 2018
Merged

Export rep_sample_n() #82

merged 7 commits into from Jan 12, 2018

Conversation

@rudeboybert
Copy link
Contributor

@rudeboybert rudeboybert commented Jan 11, 2018

Echoing @hardin47's sentiment in #44, I've found @andrewpbray's oilabs::rep_sample_n() function useful for creating sampling distributions à la tidyverse; it would be great if this function were exported.

@andrewpbray
Copy link
Collaborator

@andrewpbray andrewpbray commented Jan 12, 2018

Good idea. Credit to @mine-cetinkaya-rundel for that rep_sample_n. She wrote it back in the day and it has turned out to be a really useful function.

This is odd: travis is showing that the build fully errored out. Compare it to Ben's request, which shows that it's at least passing the current build. Any idea what's going on?

@rudeboybert
Copy link
Contributor Author

@rudeboybert rudeboybert commented Jan 12, 2018

IIRC I got some error re the vignette; I'll debug later today.

@rudeboybert
Copy link
Contributor Author

@rudeboybert rudeboybert commented Jan 12, 2018

Nope, it's something else. There is an error in the R: devel build.

@ismayc
Copy link
Collaborator

@ismayc ismayc commented Jan 12, 2018

Might be related to this https://github.com/andrewpbray/infer/pull/80 which we can tweak (I guess...) using warnings_are_errors: false to not fail the build due to the warning (https://docs.travis-ci.com/user/languages/r/#Package-check-options)

@andrewpbray
Copy link
Collaborator

@andrewpbray andrewpbray commented Jan 12, 2018

Hey Albert, could you redo this PR minus the call to pkgdown build? We just tweaked the travis.yml to hopefully have travis do the build and push it to the gh-pages branch so that we can keep the commit history on the master branch clean. Chester apologies for changing his mind =0

rudeboybert added 2 commits Jan 12, 2018
This reverts commit 665d97f.
This reverts commit d362ab7.
@rudeboybert
Copy link
Contributor Author

@rudeboybert rudeboybert commented Jan 12, 2018

Done

@andrewpbray andrewpbray merged commit 41f4648 into tidymodels:master Jan 12, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview ready!
Details
@andrewpbray
Copy link
Collaborator

@andrewpbray andrewpbray commented Jan 12, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.