Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export rep_sample_n() #82

Merged
merged 7 commits into from
Jan 12, 2018
Merged

Export rep_sample_n() #82

merged 7 commits into from
Jan 12, 2018

Conversation

rudeboybert
Copy link
Contributor

Echoing @hardin47's sentiment in #44, I've found @andrewpbray's oilabs::rep_sample_n() function useful for creating sampling distributions à la tidyverse; it would be great if this function were exported.

@andrewpbray
Copy link
Collaborator

andrewpbray commented Jan 12, 2018

Good idea. Credit to @mine-cetinkaya-rundel for that rep_sample_n. She wrote it back in the day and it has turned out to be a really useful function.

This is odd: travis is showing that the build fully errored out. Compare it to Ben's request, which shows that it's at least passing the current build. Any idea what's going on?

@rudeboybert
Copy link
Contributor Author

IIRC I got some error re the vignette; I'll debug later today.

@rudeboybert
Copy link
Contributor Author

Nope, it's something else. There is an error in the R: devel build.

@ismayc
Copy link
Collaborator

ismayc commented Jan 12, 2018

Might be related to this https://github.com/andrewpbray/infer/pull/80 which we can tweak (I guess...) using warnings_are_errors: false to not fail the build due to the warning (https://docs.travis-ci.com/user/languages/r/#Package-check-options)

@andrewpbray
Copy link
Collaborator

Hey Albert, could you redo this PR minus the call to pkgdown build? We just tweaked the travis.yml to hopefully have travis do the build and push it to the gh-pages branch so that we can keep the commit history on the master branch clean. Chester apologies for changing his mind =0

@rudeboybert
Copy link
Contributor Author

Done

@andrewpbray andrewpbray merged commit 41f4648 into tidymodels:master Jan 12, 2018
@andrewpbray
Copy link
Collaborator

Thanks!

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants