Skip to content

check data type for the model mode #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
topepo opened this issue Sep 7, 2018 · 2 comments
Closed

check data type for the model mode #51

topepo opened this issue Sep 7, 2018 · 2 comments

Comments

@topepo
Copy link
Member

topepo commented Sep 7, 2018

Test to see if integers work for classification, etc.

Should this be another module?
@topepo
Copy link
Member Author

topepo commented Sep 25, 2018

translate happens in fit and fit_xy before passing the object to the data handling functions.

parsnip:::levels_from_formula is called just before the model evaluation code to get the levels of the outcome (if any, and it doesn't currently work for spark). If we can postpone translate until after this, we could set the model mode.

topepo added a commit that referenced this issue Sep 26, 2018
@topepo
removed modes for tests related to #51
9c1dbd8
topepo added a commit that referenced this issue Sep 26, 2018
@topepo
separate retrieving the method info from the param translation for #51
a15fdca
topepo added a commit that referenced this issue Sep 26, 2018
@topepo
defer translation to after mode checking/assignment for #51
e04a9fc
@topepo topepo closed this as completed Sep 26, 2018
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@topepo