Skip to content

/ parsnip

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check data type for the model mode #51

Closed
topepo opened this issue Sep 7, 2018 · 1 comment
Closed

check data type for the model mode #51

topepo opened this issue Sep 7, 2018 · 1 comment

Comments

@topepo
Copy link
Collaborator

@topepo topepo commented Sep 7, 2018

Test to see if integers work for classification, etc.

Should this be another module?
@topepo
Copy link
Collaborator Author

@topepo topepo commented Sep 25, 2018

translate happens in fit and fit_xy before passing the object to the data handling functions.

parsnip:::levels_from_formula is called just before the model evaluation code to get the levels of the outcome (if any, and it doesn't currently work for spark). If we can postpone translate until after this, we could set the model mode.
topepo added a commit that referenced this issue Sep 26, 2018
@topepo
removed modes for tests related to #51
9c1dbd8
topepo added a commit that referenced this issue Sep 26, 2018
@topepo
separate retrieving the method info from the param translation for #51
a15fdca
topepo added a commit that referenced this issue Sep 26, 2018
@topepo
defer translation to after mode checking/assignment for #51
Loading status checks…
e04a9fc
@topepo topepo closed this Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@topepo
You can’t perform that action at this time.