-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency with return type for probability type predictions for two class GAM models #708
Comments
I forked the |
Hello @oj713 That looks great, good find! If you want to, we would be happy if you would want to create a PR, if not them I'll take it from here. |
Hi @EmilHvitfeldt, thank you! I'll go ahead and create a PR now. |
Closed via #709 |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
The problem
I'm encountering an inconsistency with generating probability predictions for two class GAM models. The predictions are being returned as arrays within a tibble, rather than just a tibble of numeric values. I believe this issue arises because
mgcv
returns an array of predictions, rather than a vector.Issue #541 covers a similar issue around GAM class predictions where
mgcv
's prediction format was also the source of the problem. I believe the fix for this problem would closely mirror the fix for that issue (fix #542).Reproducible example
Created on 2022-04-28 by the reprex package (v2.0.1)
The text was updated successfully, but these errors were encountered: