updated rlang messages in the predict functions to use cli. #1148
Merged
simonpcouch merged 3 commits intotidymodels:mainfrom Aug 28, 2024
Merged
updated rlang messages in the predict functions to use cli. #1148simonpcouch merged 3 commits intotidymodels:mainfrom
simonpcouch merged 3 commits intotidymodels:mainfrom
Conversation
simonpcouch
approved these changes
Aug 16, 2024
Contributor
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
This is a great start!
Also, please feel free to credit yourself in the package NEWS!
Contributor
|
Thanks for the PR, @shum461! Are you interested in making the changes suggested in review or would you like us to take it from here? |
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1138