Skip to content

Use cli instead of rlang for abort and warn, Fixes #1141#1154

Merged
simonpcouch merged 2 commits into
tidymodels:mainfrom
JamesHWade:convert-rlang-to-cli-predict
Aug 23, 2024
Merged

Use cli instead of rlang for abort and warn, Fixes #1141#1154
simonpcouch merged 2 commits into
tidymodels:mainfrom
JamesHWade:convert-rlang-to-cli-predict

Conversation

@JamesHWade
Copy link
Copy Markdown
Contributor

Fixes R/predict_class.R, R/predict_classprob.R, R/predict_numeric.R, and R/predict_time.R

Copy link
Copy Markdown
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! Thank you.

Comment thread R/predict_class.R Outdated
Comment thread R/predict_classprob.R Outdated
Comment thread R/predict_classprob.R Outdated
Comment thread R/predict_numeric.R
Comment thread R/predict_time.R
Copy link
Copy Markdown
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful.🚀

I just approved Actions to run—once they pass this is ready to go! Thanks so much!

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants