Divert linear regressions with poisson family to poisson_reg()#1219
Merged
Divert linear regressions with poisson family to poisson_reg()#1219
Conversation
hfrick
approved these changes
Dec 9, 2024
Member
hfrick
left a comment
hfrick
left a comment
There was a problem hiding this comment.
Nice one! For your consideration but not a request: Would it make sense to move those checks to check_args.linear_reg() or would checks on engine args in addition to main args mess with anything else?
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by tidymodels/tune#956
There are so many ways people can pass the family to
glm()andglmnet(). This checks for all four methods that I'm aware of.