added a function to get multi_predict arg names #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #' @export | ||
| #' @rdname has_multi_predict | ||
| has_multi_predict.workflow <- function(object, ...) { |
Member
There was a problem hiding this comment.
Do you think this method should live in workflows? Can you even test this function in parsnip without suggesting workflows? It's always hard to know where to put what.
Member
Author
There was a problem hiding this comment.
maybe has_multi_predict.workflow() should but the other bits should probably stay here. The workflow method is more of a place holder for when that package is more mature
It's always hard to know where to put what.
Yeah. That is becoming increasingly true.
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.