From 247cba4032d9cf868e181ce482ea3b767dde285c Mon Sep 17 00:00:00 2001 From: Emil Hvitfeldt Date: Fri, 11 Mar 2022 16:39:17 -0800 Subject: [PATCH 1/2] don't use check_outcome() when using sparklyr --- R/fit_helpers.R | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/R/fit_helpers.R b/R/fit_helpers.R index 9e820af69..731e5f839 100644 --- a/R/fit_helpers.R +++ b/R/fit_helpers.R @@ -6,7 +6,9 @@ form_form <- function(object, control, env, ...) { - check_outcome(eval_tidy(env$formula[[2]], env$data), object) + if (!inherits(env$data, "tbl_spark")) { + check_outcome(eval_tidy(env$formula[[2]], env$data), object) + } # prob rewrite this as simple subset/levels y_levels <- levels_from_formula(env$formula, env$data) From 1d8696ee634befef7fec907570b1f8ee59ace5e6 Mon Sep 17 00:00:00 2001 From: Max Kuhn Date: Mon, 14 Mar 2022 12:10:36 -0400 Subject: [PATCH 2/2] change based on reviewer feedback --- R/fit_helpers.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/fit_helpers.R b/R/fit_helpers.R index 731e5f839..61b9344b0 100644 --- a/R/fit_helpers.R +++ b/R/fit_helpers.R @@ -6,7 +6,7 @@ form_form <- function(object, control, env, ...) { - if (!inherits(env$data, "tbl_spark")) { + if (inherits(env$data, "data.frame")) { check_outcome(eval_tidy(env$formula[[2]], env$data), object) }