-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survival helpers #893
Survival helpers #893
Conversation
Could this be moved to {hardhat} instead? They would be helpful in {yardstick} which doesn't import/suggests {parsnip} |
After talking with @DavisVaughan about moving them to hardhat, he recommended putting them in a portable file that can be added to other packages via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of the standalone file! There are suggestions for you to take or leave, I just want to point you to the one .extract_surv_status()
and when it converts the status to 0
/1
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
* additional unit tests for tidymodels/parsnip#893 * import survival * namespaces since functions are now not exported * updates from reviewer feedback
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Move some code from tune to parsnip since we will relocate the IPCW code here. This PR has basic helper functions. Unit tests that require actual
Surv
objects will be in extratests